Fix the normalization for file names to work for specifying a file, p… #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filename stripping logic for file upload keys was incorrectly removing leading dots from filenames (e.g.,
.socket.facts.jsonbecamesocket.facts.json) and failed when given filenames without path separators. This caused issues when uploading dotfiles or files specified with relative/absolute paths, resulting in incorrect key names or exceptions.Root Cause
The bug was caused by:
lstrip("./")on file keys, which stripped all leading dots and slashes, not just./prefixes.rsplit("/", 1)without checking for the presence of a path separator, causing unpack errors for filenames without/.Fix
./and../prefixes and leading slashes, while preserving leading dots in filenames.Public Changelog